Re: [ros-dev] more sharing with Wine?

[Steven Edwards]

Hi Eric,

--- Eric Kohl <eric.kohl(a)t-online.de> wrote:
>   Non-portable DLLs are not portable because they use
> features that differ 
>  between ReactOS and Wine. Examples are kernel32.dll because consoles are 
>  implemented in different ways, gdi32.dll and user32.dll because the use 
>  the INT2E interface to call into win32k.sys. 
 
Yes I think we need to push the Wine people at the next Wineconf to help us make those 
dlls more portable.

>   I think we should _not_ try to make the non-portable
> DLLs portable 
>  because of the following reasons:
>  1) We always need to ensure that a DLL works on ReactOS. Wine developers 
>  cannot check whether one of their patches break a DLL on ReactOS. 
Right but we can check via regression tests. I did this with the Wine edit control in
user32. I
was able to merge all of the Wine patches in and then run the tests to make sure we still
passed.
 
>   2) Don't mix ReactOS code and Wine code. This is
> bloating the ReactOS 
>  DLLs and we'll have two sets of debug APIs (DPRINT/CHECKPOINT vs. 
>  FIXME/ERR/WARN/TRACE) in one DLL. 
I think we should just dump the ReactOS debug APIs and use the Wine ones.

>   3) Don't replace working ReactOS code just because
> you think you can. I 
>  don't want to see a lot of my work getting thrown away without a major 
>  _technical_ benefit. And I don't want to face a situation where I am at 
>  an exhibition (like LinuxWorld Expo) and a visitor tells me that the 
>  ReactOS developers didn't write any user-mode components because each 
>  and every component has been merged with Wine and the ReactOS code has 
>  been replace by Wine code just because it simplifies your work. 
And I agree with this as well. No one should blindly replace code but if 
existing ReactOS code is broken and I can point to a real world app that
needs it then we either have the option of writting it from scratch or 
seeing if we can import the Wine code. Abiword was totally hosed without
the crypto functions from Wine. I could have just stubbed the code out 
and it might have worked but at least what we have now is semi-working.

Thanks
Steven



		
__________________________________ 
Do you Yahoo!? 
Read only the mail you want - Yahoo! Mail SpamGuard. 
http://promotions.yahoo.com/new_mail