RE: [ros-dev] ** PATCH DAY 2005 ** PART I

[Ge van Geldorp]

Thomas,

You've obviously invested a lot of time and effort in this, but it seems not
in the most efficient way. For starters, I had to get winrar, only to find
that the files inside were packed with another utility. Even with the 7-Zip
I then downloaded a lot of files just refuse to open. The patch files that
do open seem to be "diff" files instead of "diff -u" which would
provide
more context.

I see a lot of the components contain the changes between Wine-20050111 and
current Wine CVS HEAD. We normally merge Wine changes after a Wine release,
that keeps the merge process manageable. Merging some arbitrary changes
between Wine releases doesn't make much sense.

Some of the files are new imports from Wine. Unfortunately, we can't just
commit those if we want to be able to keep components in sync in the future.
We need to do SVN "vendor drops", to be able to merge future updates (see
http://mok.lvcm.com/cgi-bin/reactos/roswiki?Using_Code_From_Other_Projects
on what we need to do to import code).

Other stuff doesn't belong in ReactOS alltogether, like the "start" files.
I
was unable to open that particular archive, but I assume it would give us
the Win9x start.exe utility, which we don't need, 'cause "start" is a
cmd-builtin in NT OSes. I also have doubts about some of the components we
don't share with Wine (like kernel32), but again I couldn't open those with
7-Zip.

I do appreciate the effort you put into this, and I will try to put some of
the stuff in SVN, but to be honest in its current form there's a lot of
stuff which isn't going to make it.

Ge van Geldorp.