Re: [ros-dev] Caution, Wine Tests maybe Wrong!

[Rob Shearman]

Alex Ionescu wrote:

>   Rob Shearman wrote:
>
> >   James Tabor wrote:
> >
> > > >  
> > > >  The test passes correctly on Windows, so it can't be wrong:
> > > >  rtl: 600111 tests executed, 0 marked as todo, 0 failures. 
> > >
> > >
> > >  I know, that is a problem. 
> >
> >
> >
> >  P.S. As the original author of both Wine's handle table code and the 
> >  corresponding test code, I find your sarcastic comment somewhat 
> >  insulting. 
>
>  Pardon me, but how does James' comment stating that the WINE test 
>  working on Windows but not on ReactOS is a problem become sarcastic 
>  and insulting? If anything, it was commending WINE on the quality of 
>  its test. 

The title of this thread is "Caution, Wine Tests maybe Wrong!". I 
therefore took the line "B^| Wow, -what- -a- -sur- -prise-." to mean 
that James thinks that Wine has gets things like this wrong on a regular 
basis (and incidentally, I don't dispute this, just the manner in which 
it was said). I apologise if I got the wrong end of the stick on this one.

Also, I would like to add that it may be of help to either email the 
author of the code or wine-devel if any ReactOS developers suspect they 
find bugs in Wine code. One further thing to note is that we have a 
framework set up to run tests on a variety of different Windows 
platforms and the results are published on a web site by date tested: 
http://test.winehq.org/data/

It may be helpful for someone to start performing automated tests on 
ReactOS too. Steven, you have been doing some work on fixing tests in 
the past few days: would this be useful, or are you working through the 
tests on a case-by-case basis for the moment?

Thanks,
Rob