Re: [ros-dev] [ros-diffs] [hbelusca] 63885: [KERNEL32] OpenConsoleW was implemented :P [CONSOLE.CPL][CONSRV] Create all the fonts needed at console startup, and then just select what's needed when fonts attributes need to b...

[Thomas Faber]

On 2014-08-14 22:10, hbelusca(a)svn.reactos.org wrote:
>   +    if (FaceName != GuiData->GuiInfo.FaceName)
>  +    {
>  +        SIZE_T Length = min(wcslen(FaceName) + 1, LF_FACESIZE); // wcsnlen
>  +        wcsncpy(GuiData->GuiInfo.FaceName, FaceName, LF_FACESIZE);
>  +        GuiData->GuiInfo.FaceName[Length] = L'\0'; // NULL-terminate
>  +    } 
Buffer overflow. You mean [Length - 1]