Re: [ros-dev] [ros-diffs] [jgardou] 52339: [NTOSKRNL] - don't rely on a boolean being 1 or 0, it's a bad idea (tm)

[Alex Ionescu]

???

This is retarded.

You're doing

0 ? 0 : 1

Best regards,
Alex Ionescu



On Sat, Jun 18, 2011 at 3:45 PM,  <jgardou(a)svn.reactos.org> wrote:
>   Author: jgardou
>  Date: Sat Jun 18 14:45:08 2011
>  New Revision: 52339
>
>  URL: http://svn.reactos.org/svn/reactos?rev=52339&view=rev
>  Log:
>  [NTOSKRNL]
>   - don't rely on a boolean being 1 or 0, it's a bad idea (tm)
>
>  Modified:
>     trunk/reactos/ntoskrnl/ke/i386/traphdlr.c
>
>  Modified: trunk/reactos/ntoskrnl/ke/i386/traphdlr.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/traphdlr.…
>  ==============================================================================
>  --- trunk/reactos/ntoskrnl/ke/i386/traphdlr.c [iso-8859-1] (original)
>  +++ trunk/reactos/ntoskrnl/ke/i386/traphdlr.c [iso-8859-1] Sat Jun 18 14:45:08 2011
>  @@ -1510,7 +1510,7 @@
>
>      /* Set thread fields */
>      Thread->TrapFrame = TrapFrame;
>  -    Thread->PreviousMode = KiUserTrap(TrapFrame);
>  +    Thread->PreviousMode = KiUserTrap(TrapFrame) ? UserMode : KernelMode;
>
>      /* Enable interrupts */
>      _enable();
>
>
>