Re: [ros-dev] [ros-diffs] [greatlrd] 37343: Bugfix : Do not link toLPDDRAWI_DIRECTDRAW_INT->lpLink when we do not have anyLPDDRAWI_DIRECTDRAW_INT->lpLcl

[Magnus Olsen]

Only for DirectX api big issue
In allot case in dxg.sys or win32k and the graphice drv.
They does not vaildate if it vaild pointer or not been pass down
it is up to the usermode part vaildate them inside ddraw.dll
if I pass down wrong value whole windows xp will crash to
black screeen and some part being powerdown. then the comptuer
complete froze with nice black screen. How can we vaildate the
pointer right in usermode without using IsBadWritePtr  and friends
I do not known who to solv this issue without using  IsBadWritePtr
the PSEH or _SEH can not pickup this crash at usermode when it is kmode
in the drv or dxg.sys that blows. I have try it today,

The graphic manufactor are aware of this issue but they does not check for 
all case.

I will not leave detail in public how to make whole xp goes complete dead to 
nice
black screen and some part in the comptuer have been powerdown.  It is
imposble for me see exacly what crash. I already suffer 10 of this type of 
crash
today.

Yes some parth maybe can be change to SEH
the whole HEL layer in ddraw will be use SEH
the HAL part in ddraw will not, untill I known a good
idea how this issue can be solv on XP.


This Test was done on XP SP3.


----- Original Message ----- 
From: "KJK::Hyperion" <hackbunny(a)reactos.com>
To: "ReactOS Development List" <ros-dev(a)reactos.org>
Sent: Sunday, November 16, 2008 7:32 PM
Subject: Re: [ros-dev] [ros-diffs] [greatlrd] 37343: Bugfix : Do not link 
toLPDDRAWI_DIRECTDRAW_INT->lpLink when we do not have 
anyLPDDRAWI_DIRECTDRAW_INT->lpLcl


>   Magnus Olsen wrote:
> >   1. if u warp code with PSEH it can not be optimze
> > with the compiler 
> >  (acroing
> >  KJK when he told me try avoid PSEH, long time ago). 
>  PSEH 2.0 doesn't seem to have this issue (which makes it a little risky
>  to use, maybe?)
>
> >   I can rewrite the code later to use PSEH, but I
> > do not known when I have
> >  time todo that. 
>  just remove the call to IsBadWritePtr. Don't replace it with anything
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev