Re: [ros-dev] [ros-diffs] [fireball] 50981: [NTOS/FSRTL] - Implement parameters checking i

[Ged Murphy]

Probably one of the rudest emails I've read in a long while.
You should be ashamed.


-----Original Message-----
From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On
Behalf Of Pierre Schweitzer
Sent: 06 March 2011 21:43
To: ros-dev(a)reactos.org
Subject: Re: [ros-dev] [ros-diffs] [fireball] 50981: [NTOS/FSRTL] -
Implement parameters checking i

Hi,

this commits just shows you didn't understand how that function works. If
you had, you wouldn't have said:

"- Implement parameters checking in FsRtlIsNameInExpressionPrivate."
It's already done.

"- Add two shortcuts for common wildcard invocations to make the function
faster."
If you look at the algorithm, it will take at maximum as much loop
iterations as name length.

"- Second (main part of the function) is still under review."
Thanks for discussing the issue with the original author of the algorithm,
especially since you don't understand it. Furthermore, if you're not happy
with said algorithm, you were asked to review it more than a year ago, and
for at least 6 months. Thing that you NEVER did.

So, now you discovered what my mail address is, contact me before committing
anything wrong/useless to current code.
And as you said less than a week ago, focus on fixing things that don't
work, instead of rewriting working code.

And as someone else also said once: 1:1 isn't the solution everywhere. Or if
you think so, start dropping arwinss.

Of course, don't take that personal, I like everyone ;-).

Regards,
P. Schweitzer

_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev