Re: [ros-dev] HDD Geometry switch

[Eric Kohl]

Hello Olaf,

don't you think you are overreacting a bit? Did you have a look at my 
patch? After witnessing your reaction, I do not think you had a look at 
the patch. It changes exactly 4 (four!!!!) lines of code! See the patch 
below:

/* Start of Patch */
--- trunk/reactos/drivers/storage/class/class2/class2.c	2011/04/23 
10:52:01	51437
+++ trunk/reactos/drivers/storage/class/class2/class2.c	2011/11/27 
14:18:40	54511
@@ -29,12 +29,12 @@
  #define START_UNIT_TIMEOUT  30

  /* Disk layout used by Windows NT4 and earlier versions. */
-#define DEFAULT_SECTORS_PER_TRACK    32
-#define DEFAULT_TRACKS_PER_CYLINDER  64
+//#define DEFAULT_SECTORS_PER_TRACK    32
+//#define DEFAULT_TRACKS_PER_CYLINDER  64

  /* Disk layout used by Windows 2000 and later versions. */
-//#define DEFAULT_SECTORS_PER_TRACK    63
-//#define DEFAULT_TRACKS_PER_CYLINDER 255
+#define DEFAULT_SECTORS_PER_TRACK    63
+#define DEFAULT_TRACKS_PER_CYLINDER 255

  NTSTATUS
  NTAPI
/* End of Patch */

If you really need the old geometry, you can easily change the file
drivers/storage/class/class2/class2.c to enable the old geometry again. 
You only have to enable the lines 32 and 33 and disable the lines 36 and 
37. This local modification will not be overwritten by SVN updates.


BTW, after the last WINE synch of rpcrt4.dll I spent 3 weekends to fix 
the service manager and my local changes. Did I complain? No! Because 
that's the price we have to pay if we want to improve ReactOS. Sometimes 
we have to take one step back if we want to get two steps ahead. If we 
stopped improving ReactOS as soon as the first developer or tester 
complained about a particular change, we would still boot ReactOS using 
the DOS loader and plan to release version 0.1 within the next 5 years. 
Stop crying and get over it.


Regards,
Eric

caemyr(a)myopera.com wrote:
>   I have chosen my words very carefully. I have been
> only few years within the project but this weekend's change has locked me out from
> testing, according to Eric's own words.
>
>  Others say different things, but i assume they cannot be right, since the commiter said
> what he said?
>
>  As for communication, we have also webpage, news and forum. Any word there? Not a single
> one.
>
>  Regards
>
>  On Monday, November 28, 2011 12:48 AM, "Colin Finck"<colin(a)reactos.org> 
> wrote:
> >   caemyr(a)myopera.com wrote:
> > >   Do you value your time available to spend on
> > > ReactOS? Then perhaps you could also think about others as well? 
> >  Constructively asking, what other way would we have?
> >
> >  Announcing this change some days in advance won't make things easier.
> >  And sticking to the old geometry till eternity is no solution either.
> >  Apart from this, it's a known fact that developers are only available on
> >  ros-dev or #reactos-dev. We simply have no other official communication
> >  channels for announcements like this.
> >
> >  In any case, I recommend you to choose your words more carefully towards
> >  someone who is part of the project for more than 10 years.
> >  I guess, just a few of today's developers even knew that remnants like
> >  this old disk geometry were still in use.
> >
> >  Cheers,
> >
> >  Colin
> >
> >  _______________________________________________
> >  Ros-dev mailing list
> >  Ros-dev(a)reactos.org
> >  http://www.reactos.org/mailman/listinfo/ros-dev
> >  
>