Thomas, the standard says:
"If one of the strings has an encoding prefix and the other doesn't, the one that doesn't will be considered to have the same encoding prefix as the other."
In other words, this now sends a wide-string to ASSERTMSG. Which is wrong. Best regards, Alex Ionescu
On Sun, Apr 24, 2016 at 5:14 AM, Thomas Faber thomas.faber@reactos.org wrote:
On 2016-04-20 14:16, akhaldi@svn.reactos.org wrote:
[CLASSPNP] Fix MSVC build. Brought to you by Timo.
--- trunk/reactos/drivers/storage/classpnp/class.c [iso-8859-1] (original) +++ trunk/reactos/drivers/storage/classpnp/class.c [iso-8859-1] Wed Apr 20 12:16:16 2016 @@ -877,7 +877,7 @@ status = devInfo->ClassStopDevice(DeviceObject, IRP_MN_STOP_DEVICE);
ASSERTMSG("ClassDispatchPnp !! STOP_DEVICE should "
"never be failed\n", NT_SUCCESS(status));
L"never be failed\n", NT_SUCCESS(status)); if(isFdo) { status = ClassForwardIrpSynchronous(commonExtension, Irp);This makes no sense to me at all. You're now concatenating a narrow and a wide string (which should be an error, but compilers suck), and passing it to a macro that calls RtlAssert -- which expects a narrow string. Am I missing something here?
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev