Re: [ros-dev] [ros-diffs] [hbelusca] 74528: Code simplifications.

[Thomas Faber]

On 2017-05-13 18:13, [e-mail] wrote:
> --- branches/setup_improvements/base/setup/usetup/filesup.c	[iso-8859-1] (original)
> +++ branches/setup_improvements/base/setup/usetup/filesup.c	[iso-8859-1] Sat May 13 16:13:49 2017
> @@ -524,14 +523,10 @@
>                          &IoStatusBlock,
>                          0,
>                          FILE_SYNCHRONOUS_IO_NONALERT);
>
> if (!NT_SUCCESS(Status))
>
> {
>  return FALSE;
>
> }
>
> NtClose(FileHandle);
>
> return TRUE;
> return NT_SUCCESS(Status);
>
> }

Not an improvement. You're now closing an uninitialized handle on
failure.