Re: [ros-dev] [ros-diffs] [jgardou] 53481: [WIDL] - reenable -Oif flag, it's too good to be disabled With this commit, advapi32:service winetest suffers only 2 failures.

[Eric Kohl]

Hello Jérôme,

your patch looks very good! I hope Alexandre accepts it without a length 
discussion. ;-)

I just ran another set of "advapi32_winetest service" tests on my 
machine. Both tests, with and without -Oif option return the same 
results: 2 failures! Great!

And as far as I can see our test machines return bogus results again. I 
guess we really need to reboot the test machines for each test, 
otherwise the results are useless. :-/

Regards
Eric

>   Feel free to disable it again if probems occur.
>
>  "Probable bugs" are hard to test alone, so I'm waiting for test bot to
>  confirm this fixes things without breaking others.
>
>  Regards.
>  Jérôme.