Re: [ros-dev] [ros-diffs] [ion] 59985: This commit, in my opinion, marks an important milestone in ReactOS development. One is now able to boot to desktop, launch applications, download through the application manager, play...

[Aleksey Bragin]

I just wanted to say that this is just amazing.  Being able to debug 
ReactOS with "reference" low-level DLLs is great, but being able to 
debug ReactOS ntdll and kernel32 when running them in reference 
environment (that is, Windows 2003) is even better!

Indeed, I think, having a special testbot for this would be very beneficial.

Regards,
Aleksey

On 04.09.2013 11:28, ion(a)svn.reactos.org wrote:
>   Author: ion
>  Date: Wed Sep  4 07:28:15 2013
>  New Revision: 59985
>
>  URL: http://svn.reactos.org/svn/reactos?rev=59985&view=rev
>  Log:
>  This commit, in my opinion, marks an important milestone in ReactOS development. One is
> now able to boot to desktop, launch applications, download through the application
> manager, play solitaire, minesweeper, launch Task Manager, etc... by using an unmodified
> Windows 2003 kernel32.dll binary (and, until our NPFS driver is fixed, the unmodified
> Windows 2003 NPFS driver). Additionally, one is able to achieve the same by booting with
> an unmodified Windows 2003 ntdll.dll, including a combination of both. The capability to
> mix-and-match components such as kernel32 and ntdll, at the heart of the system, will
> allow to better understand apitest failures (just as Wine has long had the capability to
> use Windows DLLs instead). With these two building blocks, additional Windows 2003 DLLs
> can be dropped in/tested, etc, and where failures are seen, a likely component can now be
> blamed. Furthermore, debugging with public symbols for these DLLs is now possible with
> WinDBG (in fact, this is how many bugs were fixed in this attempt). Many issues already
> exist when running with this combination FYI, for example, I was not able to launch any
> installers (tested Firefox and MIRC). This already demonstrates either missing
> functionality or ReactOS-specific functionality in components which depend on kernel32. I
> suspect the next step is infrastructure work to get special patchbot/builders to try and
> report back winetest results, and for additional DLLs to be "ported"/made to
> work. On a final note, this mixing and matching has benefits on both ends -- it's now
> likely that ReactOS' ntdll can run on Server 2003, at least far enough to get to
> Explorer or Task Manager. Running apitests on Server 2003 with and without reactos DLLs
> should also easily identify if certain DLLs are directly to blame for certain
> regressions/failures. </end excited rant>
>  [BASESRV]: Allocate the INI mappings from the right heap.
>
>  Modified:
>       trunk/reactos/subsystems/win/basesrv/init.c
>
>  Modified: trunk/reactos/subsystems/win/basesrv/init.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win/basesrv/ini…
>  ==============================================================================
>  --- trunk/reactos/subsystems/win/basesrv/init.c	[iso-8859-1] (original)
>  +++ trunk/reactos/subsystems/win/basesrv/init.c	[iso-8859-1] Wed Sep  4 07:28:15 2013
>  @@ -139,7 +139,7 @@
>    BaseSrvInitializeIniFileMappings(IN PBASE_STATIC_SERVER_DATA StaticServerData)
>    {
>        /* Allocate the mapping blob */
>  -    BaseSrvIniFileMapping = RtlAllocateHeap(BaseSrvHeap,
>  +    BaseSrvIniFileMapping = RtlAllocateHeap(BaseSrvSharedHeap,
>                                                HEAP_ZERO_MEMORY,
>                                                sizeof(*BaseSrvIniFileMapping));
>        if (BaseSrvIniFileMapping == NULL)
>
>