Re: [ros-dev] [ros-diffs] [hbelusca] 63135: Arch, please do not mix up ANSI vs. UNICODE string functions, do you?

[Hermès BÉLUSCA - MAÏTO]

I know, I'm currently not converting all the cmdutils to UNICODE but yes it
should be done...

Hermès.

-----Message d'origine-----
De : Ros-dev [mailto:[e-mail]] De la part de Aleksey
Bragin
Envoyé : dimanche 4 mai 2014 12:21
À : ros-dev(a)reactos.org
Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 63135: Arch, please do not mix
up ANSI vs. UNICODE string functions, do you?

Speaking of that (1000s time), the proper way would be to convert everything
to UNICODE.
It would help.

Regards,
Aleksey Bragin

On 03.05.2014 21:24, hbelusca(a)svn.reactos.org wrote:
>   Author: hbelusca
>  Date: Sat May  3 17:24:22 2014
>  New Revision: 63135
>
>  URL: http://svn.reactos.org/svn/reactos?rev=63135&view=rev
>  Log:
>  Arch, please do not mix up ANSI vs. UNICODE string functions, do you?
>
>  Modified:
>       trunk/reactos/base/applications/network/ftp/cmds.c
>
>  Modified: trunk/reactos/base/applications/network/ftp/cmds.c
>  URL: 
>  http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/net
>  work/ftp/cmds.c?rev=63135&r1=63134&r2=63135&view=diff
>  
============================================================================
==
>   ---
> trunk/reactos/base/applications/network/ftp/cmds.c	[iso-8859-1] 
(original)
>   +++
> trunk/reactos/base/applications/network/ftp/cmds.c	[iso-8859-1] 
Sat May  3 17:24:22
2014
>   @@ -1303,13 +1303,13 @@
>    
>        if (argc > 1)
>        {
>  -        strncat(CmdLine, " /C", MAX_PATH - wcslen(Cmdline) - 1);
>  +        strncat(CmdLine, " /C", MAX_PATH - strlen(Cmdline) - 1);
>        }
>    
>        for (i=1; i<argc; i++)
>        {
>  -        strncat(CmdLine, " ", MAX_PATH - wsclen(Cmdline) - 1);
>  -        strncat(CmdLine, argv[i], MAX_PATH - wsclen(Cmdline) -1);
>  +        strncat(CmdLine, " ", MAX_PATH - strlen(Cmdline) - 1);
>  +        strncat(CmdLine, argv[i], MAX_PATH - strlen(Cmdline) -1);
>        }
>    
>        StartupInfo.cb          = sizeof( StartupInfo );
>
>  

_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev