Re: [ros-dev] [ros-diffs] [dchapyshev] 53519: - Fix multiple typos and bugs, found by PVS-Studio

[Thomas Faber]

On 2011-09-03 20:07, Timo Kreuzer wrote:
>   Am 03.09.2011 13:14, schrieb Alex Ionescu:
> >   --- trunk/reactos/dll/win32/browseui/bandsite.cpp
> > [iso-8859-1] (original)
> >  +++ trunk/reactos/dll/win32/browseui/bandsite.cpp [iso-8859-1] Thu Sep  1 15:30:19 2011
> >  @@ -719,7 +719,7 @@
> >      if (fRebarWindow == NULL)
> >          return E_FAIL;
> >
> >  -    if (IsEqualIID(pguidCmdGroup, IID_IDeskBand))
> >  +    if (IsEqualIID(*pguidCmdGroup, IID_IDeskBand))
> >      {
> >          switch (nCmdID)
> >          { 
>  This looks wrong, IsEqualIID accepts GUID*, not GUID 
By chance, we've discussed this stuff for shell earlier today.
REFIID is a reference for C++.
I don't know who came up with that ingenious definition, but it should
make this correct.

-Tom