Re: [ros-dev] [ros-diffs] [hbelusca] 74617: [USETUP]: PartList module: Add a couple of disk/partition getters: GetDiskByBiosNumber, GetDiskByNumber, GetDiskBySCSI, GetDiskBySignature, GetPartition, GetDiskOrPartition. They ...

[Thomas Faber]

On 2017-05-22 01:36, hbelusca(a)svn.reactos.org wrote:
>   ---
> branches/setup_improvements/base/setup/lib/partlist.c	[iso-8859-1] (original)
>  +++ branches/setup_improvements/base/setup/lib/partlist.c	[iso-8859-1] Sun May 21
> 23:36:13 2017
>  @@ -1333,8 +1348,204 @@
>        RtlFreeHeap(ProcessHeap, 0, List);
>    }
>    
>  +PDISKENTRY
>  +GetDiskByBiosNumber(
>  +    IN PPARTLIST List,
>  +    IN ULONG BiosDiskNumber)
>  +{
>  +    PDISKENTRY DiskEntry;
>  +    PLIST_ENTRY Entry;
>  +
>  +    /* Check for empty disks */
>  +    if (IsListEmpty(&List->DiskListHead))
>  +        return NULL; 
These empty list checks look superfluous.