Please don't quote me on this, but:
- I believe the distributable code does not apply to ReactOS since it - is- a Windows platform. The driver remains a Windows platform driver. Otherwise, any driver that happens to run under BSD (with the NDISWrapper, for example) would suddently become a "non-Windows" driver. ReactOS's ability to load Windows drivers is a side-effect. As long as the driver is still a Windows driver, it should be fine. - Looking quickly through the sources, it seems the driver doesn't actually run on ReactOS in the first place -- it's missing about 40 unimplemented functions. Unless someone's planning on writing all of those, I don't believe the intent is to run this code. (See the previous commit message which talked about CDFS incompatibility). - The "distributable code" clause was added in the WDK, it wasn't there in the Server 2003 DDK. Again, from a quick look, this looks like the server 2003 driver from the DDK, not the Vista driver from the WDK.
Finally, seeing as how all original copyrights were kept, I think this is okay for now. Note that VirtualBox (A Sun owned company, now) took a couple of sample drivers from the DDK and put them into their codebase, and even stuck GPL licenses on them. I think that's way worse.
Anyways, as long as this is a 2003 DDK sample that doesn't run and isn't compiled into a binary, it should be okay. Again, don't quote me on this, just my 2 cents from having dealt with these issues before.
Worse case scenario, that directory can be ACLed by Fireball to be readable only by active developers -- much like companies can have DDK sources on an internal network share -- as long as it's not distributed outside.
On 20-Jul-08, at 3:34 PM, Heis Spiter wrote:
Indeed, that's not conform to EULA that says: "You may not distribute Distributable Code to run on a platform other than the Windows platform;". Moreover, CDFS driver ISN'T listed as a "Distributable Code". Please revert to avoid any problems. P. Schweitzer
From: "Steven Edwards" winehacker@gmail.com Sent: Monday, July 21, 2008 12:21 AM To: ros-dev@reactos.org Subject: Re: [ros-dev] [ros-diffs] [ros-arm-bringup] 34615: - Add new CDFSdriver. - Does not compile.
On Sun, Jul 20, 2008 at 3:52 PM, ros-arm-bringup@svn.reactos.org wrote:
URL: http://svn.reactos.org/svn/reactos?rev=34615&view=rev Log:
- Add new CDFS driver.
- Does not compile.
Ehem...as far as I understand the EULA (unless its changed) you cannot use the WDK references drivers for a non-windows OS. Please revert this and write you own.
-- Steven Edwards
"There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo _______________________________________________ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Best regards, Alex Ionescu