Re: [ros-dev] [ros-diffs] [fireball] 53596: [NTOS/CONFIG] - Remove unnecessary assignments. Spotted by PVS and Dmitry Chapyshev. This may change the behaviour of that codepath, so test results are going to be observed.

[Alex Ionescu]

Is this a joke?

Best regards,
Alex Ionescu


On Mon, Sep 5, 2011 at 12:55 PM, Aleksey Bragin <aleksey(a)reactos.org> wrote:

>     Let me guess, do you want it to be
>  ChildList = &(Kcb->ValueCache);
>
>  ?
>
>  WBR,
>  Aleksey.
>
>   *From:* Alex Ionescu <ionucu(a)videotron.ca>
>  *Sent:* Monday, September 05, 2011 3:46 PM
>  *To:* ros-dev(a)reactos.org
>  *Cc:* ros-diffs(a)reactos.org
>  *Subject:* Re: [ros-dev] [ros-diffs] [fireball] 53596: [NTOS/CONFIG] -
>  Remove unnecessary assignments. Spotted by PVS and Dmitry Chapyshev. This
>  may change the behaviour of that codepath, so test results are going to be
>  observed.
>
>  Uhhhh...
>
>  Am I really the *only* one who sees a problem here?
>
>  ChildList = &Kcb->ValueCache;
>  -    ChildList = (PCACHED_CHILD_LIST)&KeyNode->ValueList;
>
>  Best regards,
>  Alex Ionescu
>
>
>  On Mon, Sep 5, 2011 at 10:54 AM, <fireball(a)svn.reactos.org> wrote:
>
> >   Author: fireball
> >  Date: Mon Sep  5 09:54:20 2011
> >  New Revision: 53596
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=53596&view=rev
> >  Log:
> >  [NTOS/CONFIG]
> >  - Remove unnecessary assignments. Spotted by PVS and Dmitry Chapyshev.
> >  This may change the behaviour of that codepath, so test results are going to
> >  be observed.
> >
> >  Modified:
> >     trunk/reactos/ntoskrnl/config/cmvalche.c
> >
> >  Modified: trunk/reactos/ntoskrnl/config/cmvalche.c
> >  URL:
> >
> > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmvalche.c…
> >
> >  ==============================================================================
> >  --- trunk/reactos/ntoskrnl/config/cmvalche.c [iso-8859-1] (original)
> >  +++ trunk/reactos/ntoskrnl/config/cmvalche.c [iso-8859-1] Mon Sep  5
> >  09:54:20 2011
> >  @@ -49,7 +49,6 @@
> >      PHHIVE Hive;
> >      PCACHED_CHILD_LIST ChildList;
> >      HCELL_INDEX CellToRelease;
> >  -    PCM_KEY_NODE KeyNode;
> >
> >      /* Set defaults */
> >      *ValueListToRelease = HCELL_NIL;
> >  @@ -58,8 +57,6 @@
> >      /* Get the hive and value cache */
> >      Hive = Kcb->KeyHive;
> >      ChildList = &Kcb->ValueCache;
> >  -    KeyNode = (PCM_KEY_NODE)HvGetCell(Hive, Kcb->KeyCell);
> >  -    ChildList = (PCACHED_CHILD_LIST)&KeyNode->ValueList;
> >
> >      /* Check if the value is cached */
> >      if (CmpIsValueCached(ChildList->ValueList))
> >  @@ -212,7 +209,6 @@
> >      BOOLEAN IndexIsCached;
> >      ULONG i = 0;
> >      HCELL_INDEX Cell = HCELL_NIL;
> >  -    PCM_KEY_NODE KeyNode;
> >
> >      /* Set defaults */
> >      *CellToRelease = HCELL_NIL;
> >  @@ -221,8 +217,6 @@
> >      /* Get the hive and child list */
> >      Hive = Kcb->KeyHive;
> >      ChildList = &Kcb->ValueCache;
> >  -    KeyNode = (PCM_KEY_NODE)HvGetCell(Hive, Kcb->KeyCell);
> >  -    ChildList = (PCACHED_CHILD_LIST)&KeyNode->ValueList;
> >
> >      /* Check if the child list has any entries */
> >      if (ChildList->Count != 0)
> >
> >
> >  
>  ------------------------------
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>
>