Re: [ros-dev] [ros-diffs] [cmihail] 53541: [shell32.dll] - Don't do some parameter checks, even if MSDN says they're incompatible. Winetests with windows 2003 server as reference tells us msdn lies. (Spotted by Victor Marti...

[Alex Ionescu]

Just because the checks aren't in THIS api doesn't mean MSDN lies.

Best regards,
Alex Ionescu


On Sat, Sep 3, 2011 at 11:55 AM, <cmihail(a)svn.reactos.org> wrote:

>   Author: cmihail
>  Date: Sat Sep  3 10:55:51 2011
>  New Revision: 53541
>
>  URL: http://svn.reactos.org/svn/reactos?rev=53541&view=rev
>  Log:
>  [shell32.dll]
>  - Don't do some parameter checks, even if MSDN says they're incompatible.
>  Winetests with windows 2003 server as reference tells us msdn lies. (Spotted
>  by Victor Martinez)
>
>  Modified:
>     branches/shell32_new-bringup/dll/win32/shell32/shell32_main.cpp
>
>  Modified: branches/shell32_new-bringup/dll/win32/shell32/shell32_main.cpp
>  URL:
>
> http://svn.reactos.org/svn/reactos/branches/shell32_new-bringup/dll/win32/s…
>
>  ==============================================================================
>  --- branches/shell32_new-bringup/dll/win32/shell32/shell32_main.cpp
>  [iso-8859-1] (original)
>  +++ branches/shell32_new-bringup/dll/win32/shell32/shell32_main.cpp
>  [iso-8859-1] Sat Sep  3 10:55:51 2011
>  @@ -330,9 +330,6 @@
>            (flags & SHGFI_PIDL)? "pidl" : debugstr_w(path),
>  dwFileAttributes,
>            psfi, psfi->dwAttributes, sizeofpsfi, flags);
>
>  -    if ( (flags & SHGFI_USEFILEATTRIBUTES) &&
>  -         (flags & (SHGFI_ATTRIBUTES|SHGFI_EXETYPE|SHGFI_PIDL)))
>  -        return FALSE;
>      if (!path)
>           return FALSE;
>
>
>
>