Re: [ros-dev] [ros-diffs] [hbelusca] 72997: [KERNEL32]: Mark Get/SetEnvironmentVariableA/W as hotpatchable since it's needed for Clink 0.4.8 (<rant>btw, if GCC was able to set exported stdcall functions as hotpatchable at a...

[Timo Kreuzer]

What about adding it to WINAPI?

#ifdef _HOTPATCH_MODULE_
#define WINAPI __stdcall DECLSPEC_HOTPATCH
#else
#endif
#define WINAPI __stdcall
Timo

Am 20.10.2016 um 00:26 schrieb hbelusca(a)svn.reactos.org:
>   Author: hbelusca
>  Date: Wed Oct 19 22:26:04 2016
>  New Revision: 72997
>
>  URL: http://svn.reactos.org/svn/reactos?rev=72997&view=rev
>  Log:
>  [KERNEL32]: Mark Get/SetEnvironmentVariableA/W as hotpatchable since it's needed for
> Clink 0.4.8 (<rant>btw, if GCC was able to set exported stdcall functions as
> hotpatchable at a global level, as MSVC does, those "DECLSPEC_HOTPATCH" hacks
> would not be necessary! </rant>)
>
>  Modified:
>       trunk/reactos/dll/win32/kernel32/client/environ.c
>
>  Modified: trunk/reactos/dll/win32/kernel32/client/environ.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/…
>  ==============================================================================
>  --- trunk/reactos/dll/win32/kernel32/client/environ.c	[iso-8859-1] (original)
>  +++ trunk/reactos/dll/win32/kernel32/client/environ.c	[iso-8859-1] Wed Oct 19 22:26:04
> 2016
>  @@ -24,6 +24,7 @@
>     */
>    DWORD
>    WINAPI
>  +DECLSPEC_HOTPATCH
>    GetEnvironmentVariableA(IN LPCSTR lpName,
>                            IN LPSTR lpBuffer,
>                            IN DWORD nSize)
>  @@ -158,6 +159,7 @@
>     */
>    DWORD
>    WINAPI
>  +DECLSPEC_HOTPATCH
>    GetEnvironmentVariableW(IN LPCWSTR lpName,
>                            IN LPWSTR lpBuffer,
>                            IN DWORD nSize)
>  @@ -212,6 +214,7 @@
>     */
>    BOOL
>    WINAPI
>  +DECLSPEC_HOTPATCH
>    SetEnvironmentVariableA(IN LPCSTR lpName,
>                            IN LPCSTR lpValue)
>    {
>  @@ -252,6 +255,7 @@
>     */
>    BOOL
>    WINAPI
>  +DECLSPEC_HOTPATCH
>    SetEnvironmentVariableW(IN LPCWSTR lpName,
>                            IN LPCWSTR lpValue)
>    {
>
>
>