Re: [ros-dev] Re: [ros-diffs] [ea] 18230: More fixes to compile.

[Emanuele Aliberti]

Alex Ionescu wrote:

>   ea(a)svn.reactos.com wrote:
>
> >   More fixes to compile.
> >
> >  Modified: trunk/reactos/subsys/csr/csrsrv/api.c
> >  Modified: trunk/reactos/subsys/csr/csrsrv/process.c
> >   
> >
> >  ------------------------------------------------------------------------
> >  *Mo* 
>
>  What compiler are you using? My gcc 3.4.4 compiled the files 
>  perfectly, so did msvc 2k5 with maximum prefast warnings on. 
>  Initializing all those variables to NULL seems an awful waste to me..
>  
d:\src\ros\trunk>gcc --version
gcc (GCC) 3.4.2 (mingw-special)
Copyright (C) 2004 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


Is it obsolete? It stopped compiling because it found possibly 
uninitialized variables. IMHO inizializing variables is good practice in 
safe programming.

-- 
:Emanuele Aliberti