Re: [ros-dev] [ros-diffs] [cgutman] 46237: - Add a hack to disable ACPI if VMwar

[Andrew Faulds]

What? The HAL doesn't support ACPI currently?!
On 17 March 2010 16:08, Ros Arm <ros.arm(a)reactos.org> wrote:
>   I had told the channel not to do this because HAL ACPI
> does not exist yet.
>  ACPI cannot work without it, other than by random chance or coincidence.
>  -r
> >   Very nasty.
> >  --------------------------------------------------
> >  From: <cgutman(a)svn.reactos.org>
> >  Sent: Wednesday, March 17, 2010 8:02 AM
> >  To: <ros-diffs(a)reactos.org>
> >  Subject: [ros-diffs] [cgutman] 46237: - Add a hack to disable ACPI if 
>  VMware
> >   is detected - This hack circumvents the main
> > blocker that prevents 
>  enabling
> >   ACPI in trunk
> >  > Author: cgutman
> >  > Date: Wed Mar 17 06:02:06 2010
> >  > New Revision: 46237
> >  >
> >  > URL: http://svn.reactos.org/svn/reactos?rev=46237&view=rev
> >  > Log:
> >  > - Add a hack to disable ACPI if VMware is detected
> >  > - This hack circumvents the main blocker that prevents enabling ACPI in
> >  > trunk
> >  >
> >  > Modified:
> >  >    trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c
> >  >
> >  > Modified: trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c
> >  > URL:
> >  > 
> http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/acpi/acpica/ta…
> >   > 
> ==============================================================================
>  > > --- trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c [iso-8859-1]
>  > > (original)
>  > > +++ trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c [iso-8859-1]
>  > > Wed Mar 17 06:02:06 2010
>  > > @@ -592,6 +592,7 @@
>  > >     UINT32                  Length;
>  > >     UINT8                   *TableEntry;
>  > >     ACPI_STATUS             Status;
>  > > +    ACPI_TABLE_HEADER       LocalHeader;
> >   > 
> >   > 
>  > >     ACPI_FUNCTION_TRACE (TbParseRootTable);
>  > > @@ -645,6 +646,14 @@
>  > >     }
> >   > 
>  > >     AcpiTbPrintTableHeader
> (Address, Table);
>  > > +
>  > > +    AcpiTbCleanupTableHeader (&LocalHeader, Table);
>  > > +    if (strstr(LocalHeader.AslCompilerId, "VMW"))
>  > > +    {
>  > > +        ACPI_ERROR ((AE_INFO, "VMware detected; ACPI has been
>  > > disabled\n"));
>  > > +        AcpiOsUnmapMemory (Table, sizeof (ACPI_TABLE_HEADER));
>  > > +        return_ACPI_STATUS (AE_ERROR);
>  > > +    }
> >   > 
>  > >     /* Get the length of
> the full table, verify length and map entire
>  > > table */
> >   > 
> >   > 
> >   > 
>  >
>  > _______________________________________________
>  > Ros-dev mailing list
>  > Ros-dev(a)reactos.org
>  > http://www.reactos.org/mailman/listinfo/ros-dev
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>  
--
Andrew Faulds (andrewros/andrewweb)
http://ajf.me/