Re: [ros-dev] [ros-diffs] [hbelusca] 69160: [EFISYS]: Add 'bcd_hive' as a dependency. [FATTEN]: Fix help message. Functions with no parameters are void. Remove an hardcoded array size.

[Thomas Faber]

Hey Hermès,
I'm fixing how the BCD hive is generated and this just showed up in an
svn blame for me.
Can you explain why this bcd_hive dependency is needed? I don't see the
command depending on the hive file.

Thanks,
Thomas


On 2015-09-09 21:48, hbelusca(a)svn.reactos.org wrote:
>   Author: hbelusca
>  Date: Wed Sep  9 19:48:15 2015
>  New Revision: 69160
>  
>  URL: http://svn.reactos.org/svn/reactos?rev=69160&view=rev
>  Log:
>  [EFISYS]: Add 'bcd_hive' as a dependency.
>  [FATTEN]: Fix help message. Functions with no parameters are void. Remove an hardcoded
> array size.
>  
>  Modified:
>      trunk/reactos/boot/CMakeLists.txt
>      trunk/reactos/tools/fatten/fatten.c
>  
>  Modified: trunk/reactos/boot/CMakeLists.txt
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/boot/CMakeLists.txt?rev=69…
>  ==============================================================================
>  --- trunk/reactos/boot/CMakeLists.txt	[iso-8859-1] (original)
>  +++ trunk/reactos/boot/CMakeLists.txt	[iso-8859-1] Wed Sep  9 19:48:15 2015
>  @@ -17,7 +17,7 @@
>   
>   add_custom_target(efisys
>       COMMAND native-fatten ${CMAKE_CURRENT_BINARY_DIR}/efisys.bin -format 2880 EFIBOOT
> -boot ${CMAKE_CURRENT_BINARY_DIR}/freeldr/bootsect/fat.bin -mkdir EFI -mkdir EFI/BOOT -add
> $<TARGET_FILE:bootmgfw> EFI/BOOT/boot${EFI_PLATFORM_ID}.efi -add
> ${CMAKE_BINARY_DIR}/boot/bootdata/BCD EFI/BOOT/BCD
>  -    DEPENDS native-fatten bootmgfw fat
>  +    DEPENDS native-fatten fat bootmgfw bcd_hive
>       VERBATIM)
>   
>   ##bootcd
>