Re: [ros-dev] [ros-diffs] [cgutman] 37248: - Check the status of IPSendDatagram - Validate the protocol - Use the hash value of the NCE address to get the lock - Simplify TCPAbortListenForSocket - Hardcode the length of the array

[Aleksey Bragin]

On Nov 7, 2008, at 11:31 PM, cgutman(a)svn.reactos.org wrote:

>   Author: cgutman
>  Date: Fri Nov  7 14:31:34 2008
>  New Revision: 37248
>
>  URL: http://svn.reactos.org/svn/reactos?rev=37248&view=rev
>  Log:
>   - Check the status of IPSendDatagram
>   - Validate the protocol
>   - Use the hash value of the NCE address to get the lock
>   - Simplify TCPAbortListenForSocket
>   - Hardcode the length of the array
>
>  +    HashValue  = *(PULONG)(&NCE->Address.Address);
>  +    HashValue ^= HashValue >> 16;
>  +    HashValue ^= HashValue >> 8;
>  +    HashValue ^= HashValue >> 4;
>  +    HashValue &= NB_HASHMASK; 
It's used at least three times in the source code, I would do an  
inline hash-calculating function for that.