25 Oct
2010
25 Oct
'10
6:43 p.m.
Hi,
good to see the branch work back in trunk, I suspected this work would be
left to rot and finally be forgotten (like in most other experimental
branches). Altogether this looks like a huge step forward, got to test those
mode switches it once I have enough time.
One thing I noticed from the diffs is the eng/mem.c file, which exceeded my
EVIL / HACK threshold. Is this supposed to stay - especially in the context
of ARM3's to be proven awesomeness?
--- snippet ---
EngSecureMem(PVOID Address, ULONG Length)
{ return (HANDLE)-1; // HACK!!! }
EngUnsecureMem(HANDLE Mem)
{ if (Mem == (HANDLE)-1) return; // HACK!!! }
--- snippet ---
Good work anyway, thanks to the people involved!
Regards,
Gregor