Re: [ros-dev] [ros-diffs] [hbelusca] 70713: [WIN32SS] - Fix orthograph - Mention in the code that some stuff are hacks & need to be fixed. - Add parentheses around bit checks.

[James Tabor]

So,
While the taskbar has gone away, the icon'ized window should be at the
bottom of the window just like MDI windowing?

On Sat, Feb 13, 2016 at 6:42 AM, Hermès BÉLUSCA - MAÏTO <
hermes.belusca(a)sfr.fr&gt; wrote:

>   OK not a hack, but something that needs to be fixed
> asap. (btw you can see
>  the problem when you have an app running and you kill explorer so that you
>  don’t have any taskbar remaining. Now minimize your app à it completely
>  disappear).
>
>  H.
>
>
>
>  *De :* Ros-dev [mailto:[e-mail]] *De la part de* James
>  Tabor
>  *Envoyé :* samedi 13 février 2016 06:02
>  *À :* ReactOS Development List
>  *Objet :* [ros-dev] [ros-diffs] [hbelusca] 70713: [WIN32SS] - Fix
>  orthograph - Mention in the code that some stuff are hacks & need to be
>  fixed. - Add parentheses around bit checks.
>
>
>
>  Hello,
>
>  Why is this a hack?
>
>  Thanks,
>  James
>
>
>  Modified: trunk/reactos/win32ss/user/ntuser/winpos.c
>
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/winpos…
>
>  ==============================================================================
>
>  --- trunk/reactos/win32ss/user/ntuser/winpos.c       [iso-8859-1] (original)
>
>  +++ trunk/reactos/win32ss/user/ntuser/winpos.c       [iso-8859-1] Fri Feb 12 16:40:36
> 2016
>
>  @@ -724,8 +724,8 @@
>
>      pwndParent = Window->spwndParent;
>
>      if (pwndParent == UserGetDesktopWindow())
>
>      {
>
>  -      ERR("Parent is Desktop, Min off screen!\n");
>
>  -      /* ReactOS doesn't support iconic minimize to desktop */
>
>  +      ERR("FIXME: Parent is Desktop, Min off screen!\n");
>
>  +      /* FIXME: ReactOS doesn't support iconic minimize to desktop */
>
>         Pos->x = Pos->y = -32000;
>
>         Window->InternalPos.flags |= WPF_MININIT;
>
>         Window->InternalPos.IconPos.x = Pos->x;
>
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>