Re: [ros-dev] [ros-diffs] 01/01: [WIN32SS] Fix NtUserGetClipboardData for text paste (#645)

[Hermès BÉLUSCA-MAÏTO]

Hello,

This commit, as well as the following one: 0a8cd95cad36e7518ddb7256b3af9169789285f7 -
"[USERINIT][EXPLORER] Fix auto startup of Start Menu (#594)"
that caused the apparition of a strange timeout during the "kernel32 :
ConsoleCP" test (has been investigated by Mark, see
https://jira.reactos.org/browse/CORE-14763 )
seems to expose an already-existing bug in win32k related to window painting.

Indeed, the problems appear to be fixed by this PR:
https://github.com/reactos/reactos/pull/674
and fixes the testbots as you can see:
https://build.reactos.org/builders/Test%20KVM/builds/20737
https://build.reactos.org/builders/Test%20KVM/builds/20738

If everything goes well, I will commit the PR during the weekend.

Best regards,
Hermès

>   -----Message d'origine-----
>  De : Ros-dev [mailto:[e-mail]] De la part de Pierre
>  Schweitzer
>  Envoyé : mercredi 4 juillet 2018 07:41
>  À : ros-dev(a)reactos.org; Katayama Hirofumi MZ
>  Objet : Re: [ros-dev] [ros-diffs] 01/01: [WIN32SS] Fix NtUserGetClipboardData
>  for text paste (#645)
>  
>  For the record, that commit seems to have broken ReactOS testing (see
>  testman, which records last successful test run for 2170901, ie, previous
>  commit).
>  
>  Starting with that commit, any regression test run never ends.
>  It seems bug reports have been creating regarding regressions (timeouts) in
>  the tests but got ignored so far.
>  
>  It would be great to fix these before pushing any other commits.
>  
>  Cheers,
>  Pierre
>  
>  Le 30/06/2018 à 17:12, Katayama Hirofumi MZ a écrit :
> >  
> > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6abc9f5b5af6cc7b
> >  7c57ff9c6bcc4a919cf85d1e
> >
> >  commit 6abc9f5b5af6cc7b7c57ff9c6bcc4a919cf85d1e
> >  Author:     Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com>
> >  AuthorDate: Sun Jul 1 00:12:23 2018 +0900
> >  Commit:     Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito(a)reactos.org>
> >  CommitDate: Sat Jun 30 17:12:23 2018 +0200
> >
> >      [WIN32SS] Fix NtUserGetClipboardData for text paste (#645)
> >
> >      Fix the NtUserGetClipboardData function for the synthesized text formats 
> (CF_TEXT, CF_OEMTEXT and CF_UNICODETEXT).
> >       CORE-11471
> >  ---  
>  
>  --
>  Pierre Schweitzer <pierre at reactos.org> System & Network Administrator
>  Senior Kernel Developer ReactOS Deutschland e.V.