Re: [ros-dev] [ros-diffs] [sginsberg] 36773: - Unbreak GetTextFaceA/W, broken since 28730 by GreatLord

[Matthew Therault]

Agreed.... Everyone makes mistakes.  You should point out mistakes in the
least personal matter. People don't learn if you attack them personally, and
they tend to shut off towards others.

On Thu, Oct 16, 2008 at 5:08 PM, gedmurphy <gedmurphy(a)gmail.com> wrote:

>   Why do you need to publically state it was broken and
> who broke it?
>  Does it make you feel more important and help to boost your ego?
>
>
>
>  -----Original Message-----
>  From: ros-diffs-bounces(a)reactos.org [mailto:[e-mail]]
>  On Behalf Of sginsberg(a)svn.reactos.org
>  Sent: 16 October 2008 21:02
>  To: ros-diffs(a)reactos.org
>  Subject: [ros-diffs] [sginsberg] 36773: - Unbreak GetTextFaceA/W, broken
>  since 28730 by GreatLord
>
>  Author: sginsberg
>  Date: Thu Oct 16 15:02:22 2008
>  New Revision: 36773
>
>  URL: http://svn.reactos.org/svn/reactos?rev=36773&view=rev
>  Log:
>  - Unbreak GetTextFaceA/W, broken since 28730 by GreatLord
>
>  Modified:
>     trunk/reactos/dll/win32/gdi32/objects/text.c
>
>  Modified: trunk/reactos/dll/win32/gdi32/objects/text.c
>  URL:
>
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/gdi32/objects/te…
>
>  ==============================================================================
>  --- trunk/reactos/dll/win32/gdi32/objects/text.c [iso-8859-1] (original)
>  +++ trunk/reactos/dll/win32/gdi32/objects/text.c [iso-8859-1] Thu Oct 16
>  15:02:22 2008
>  @@ -358,20 +358,24 @@
>   * @implemented
>   */
>   INT
>  -STDCALL
>  +WINAPI
>   GetTextFaceW(HDC hDC,
>  -             int nCount,
>  -             LPWSTR    lpFaceName)
>  -{
>  -    INT retValue = 0;
>  -    if ((!lpFaceName) || (nCount))
>  -    {
>  -        retValue = NtGdiGetTextFaceW(hDC,nCount,lpFaceName,0);
>  +             INT nCount,
>  +             PWSTR pFaceName)
>  +{
>  +    INT retValue;
>  +
>  +    if ((pFaceName && nCount) ||
>  +        !(pFaceName && nCount))
>  +    {
>  +        retValue = NtGdiGetTextFaceW(hDC, nCount, pFaceName, 0);
>      }
>      else
>      {
>          SetLastError(ERROR_INVALID_PARAMETER);
>  -    }
>  +        retValue = 0;
>  +    }
>  +
>      return retValue;
>   }
>
>
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>  


-- 
Two men walk into a bar....... Third one ducks....

Think about it, it will come to you.  :P