Re: [ros-dev] [ros-diffs] [jgardou] 49396: [CMAKE] - put ntdll.def in source files

[Ged Murphy]

I've just tried to build the cmake branch for the first time and hit the following
error :


-- xmllite has no base address
-- win32csr has no base address
-- Configuring done
CMake Error in dll/ntdll/CMakeLists.txt:
  Cannot find source file "ntdll.def".  Tried extensions .c .C .c++ .cc .cpp
  .cxx .m .M .mm .h .hh .h++ .hm .hpp .hxx .in .txx



Reverting the changes in this revision fixed it.
I know nothing about cmake, but this change appears to have broken the build?

Ged.



-----Original Message-----
From: ros-diffs-bounces(a)reactos.org [mailto:[e-mail]] On Behalf Of
jgardou(a)svn.reactos.org
Sent: 01 November 2010 09:32
To: ros-diffs(a)reactos.org
Subject: [ros-diffs] [jgardou] 49396: [CMAKE] - put ntdll.def in source files

Author: jgardou
Date: Mon Nov  1 09:32:04 2010
New Revision: 49396

URL: http://svn.reactos.org/svn/reactos?rev=49396&view=rev
Log:
[CMAKE]
  - put ntdll.def in source files

Modified:
    branches/cmake-bringup/dll/ntdll/CMakeLists.txt

Modified: branches/cmake-bringup/dll/ntdll/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/branches/cmake-bringup/dll/ntdll/CMakeLi…
==============================================================================
--- branches/cmake-bringup/dll/ntdll/CMakeLists.txt [iso-8859-1] (original)
+++ branches/cmake-bringup/dll/ntdll/CMakeLists.txt [iso-8859-1] Mon Nov  1 09:32:04 2010
@@ -21,10 +21,8 @@
     rtl/libsupp.c
     rtl/version.c
     def/ntdll.rc
-    def/ntdll.def)
+    ${CMAKE_CURRENT_BINARY_DIR}/def/ntdll.def)
     
-set_source_files_properties(def/ntdll.def PROPERTIES EXTERNAL_OBJECT TRUE)
-
 if(ARCH MATCHES i386)
 list(APPEND SOURCE dispatch/i386/dispatch.S)
 elseif(ARCH MATCHES amd64)
@@ -48,7 +46,6 @@
 endif()
 
 target_link_libraries(ntdll
-    ${CMAKE_CURRENT_BINARY_DIR}/def/ntdll.def
                       ntdllsys
                       libcntpr
                       pseh)