[ros-dev] Old Code in User32

[James Tabor]

Hi all!
I noticed we still have drawing issues even after fixing some gdi
code. Well, I guess we need to look at the main windowing side of the
house now. I guess, based on a stable release we can sync up wine and
patch by hand the forked code too. I know of some Delphi issues that
could use a good non static update. Bulk of our user code is from wine
and that includes the window positioning bug everyone has had a crack
at as well. I notices that most of the syncs in comdlg/controls depend
on user code updates. If Richedit breaks windowing, it could be
related to user32/win32k code not updated or based on behavior that is
wrong. Syncing and updating forked code is not fun, with both, one
needs to take into account local fixes. When you find them, mark them
like "REACTOS HACK" or "REACTOS ONLY" or "REACTOS ????" what
ever.
Reading the change logs for each file should help with determining
local patches that have been applied and need to be taken into account
as well. If you have a bug report, please mark it as WINE SYNC or WINE
UPDATE, something to let us know, it's a wine sync of some kind. We
have a file in our media doc directory that holds the sync/fork
information, please include it with your updates.

Thanks,
James

Ref: README.WINE:
User32 -
   reactos/dll/win32/user32/controls/button.c    # Synced to Wine-1_1_13
   reactos/dll/win32/user32/controls/combo.c     # Synced to Wine-1_1_13
   reactos/dll/win32/user32/controls/edit.c      # Synced to Wine-1_1_13
   reactos/dll/win32/user32/controls/icontitle.c # Synced to Wine-1_1_13
   reactos/dll/win32/user32/controls/listbox.c   # Synced to Wine-1_1_13
   reactos/dll/win32/user32/controls/scrollbar.c # Forked
   reactos/dll/win32/user32/controls/static.c    # Synced at 20071024

   reactos/dll/win32/user32/misc/dde.c           # Synced to wine
1.1.17 (dde_misc.c)
   reactos/dll/win32/user32/misc/ddeclient.c     # Synced to wine 1.1.17
   reactos/dll/win32/user32/misc/ddeserver.c     # Synced to wine 1.1.17
   reactos/dll/win32/user32/misc/exticon.c       # Last sync date unknown
   reactos/dll/win32/user32/misc/resources.c     # Forked?
   reactos/dll/win32/user32/misc/winhelp.c       # Last sync date unknown
   reactos/dll/win32/user32/misc/wsprintf.c      # Synced to Wine-1_1_13

   reactos/dll/win32/user32/windows/defwnd.c     # Forked
   reactos/dll/win32/user32/windows/draw.c       # Forked at
Wine-20020904 (uitools.c)
   reactos/dll/win32/user32/windows/mdi.c        # Synced at 20060703
   reactos/dll/win32/user32/windows/menu.c       # Forked
   reactos/dll/win32/user32/windows/messagebox.c # Forked
   reactos/dll/win32/user32/windows/rect.c       # Forked (uitools.c)
   reactos/dll/win32/user32/windows/text.c       # Forked (lstr.c)
   reactos/dll/win32/user32/windows/winpos.c     # Forked