29 Jun
2011
29 Jun
'11
6:31 p.m.
The names in folders are for copyright notification, or at least I treat it
as such. The people listed are people who have actually added something and
thus have a copyright claim to some of the work in the file. Format
shifting, which is what this utf-8 conversion is, does not constitute
producing something that one can claim to have contributed to to the point
of also having a copyright to some of it. If someone did spelling fixes or
bug fixes or the like, they would indeed deserve to have their names added
on. The utf-8 conversion does not. People doing the conversion get a
mention in the SVN logs and will likely get listed on the changelog for
their help, but listing them in the file is erroneous.
On Wed, Jun 29, 2011 at 12:26 PM, <caemyr(a)myopera.com> wrote:
Our resource headers are kind of a mess. I suspect
that he did the same
thing as I (adding a header line whenever i translate/fix/update given
resource file - as i`m reviewing translations while doing so, this allows me
to sort out the reviewed files from the ones i never seen before.
I also marked the files I converted to UTF-8. Why? When i`m done, i`m
planning to just dump the full module list and review/update our module
translation list in translation wiki.
Apart from that, we are adding info about programmers to modules they
created. Why aren't you Zachary objecting to it?
In my opinion if someone made an effort or contribution for the project's
modules, be it not only coding but translating or simply converting and
making sure its correct, a single line within module affected is not really
a gross thing to ask for?
Anyway, since i started upkeeping polish locale, almost 3 years ago, there
was absolutely no standard to follow. I created my own, cherry-picked from
elements i liked best from what i seen around, and was sticking to it.
Marking changes by a short line within module file, was one of the things i
adopted. There were others, like for example sorting includes in rsrc.rc
files in alphabetical order. No one objected back then.
On Wed, 29 Jun 2011 10:46 +0400, "Aleksey Bragin" <aleksey(a)reactos.org>
wrote:
I fully agree too, it's nothing bad just a
matter of consistent style.
WBR,
Aleksey.
With best regards
Caemyr
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev