Oh, and don't even get me started on the PAGES AND PAGES of debug output that the ACPI driver does: http://build.reactos.org/builders/Windows_AMD64_1%20VBox-Test/builds/2939/steps/test/logs/stdio
Can you please justify the following:1) WARNING: HvpWriteLog at P:\Trunk_slave\x86_CMake\build\lib\cmlib\hivewrt.c:26 is UNIMPLEMENTED!
repeated 5-6 times per flush.2_ (P:\Trunk_slave\x86_CMake\build\ntoskrnl\po\povolume.c:312)
And friends, which happen every shutdown and detail every single operation (along with poshtdown.c and power.c)Useless:(P:\Trunk_slave\x86_CMake\build\drivers\bus\pci\fdo.c:586) Unknown IOCTL 0x9 (P:\Trunk_slave\x86_CMake\build\drivers\bus\pci\fdo.c:586) Unknown IOCTL 0x14
(P:\Trunk_slave\x86_CMake\build\ntoskrnl\io\pnpmgr\pnproot.c:1137) IRP_MJ_PNP / Unknown minor function 0x3
Too much information:
(P:\Trunk_slave\x86_CMake\build\ntoskrnl\mm\ARM3\sysldr.c:168) Loading: \SystemRoot\system32\drivers\mouclass.sys at F886E000 with 23 pages
WARNING: RtlSetUnhandledExceptionFilter at P:\Trunk_slave\x86_CMake\build\lib\rtl\exception.c:186 is UNIMPLEMENTED!
Happens 15-6 times+ per boot.
And more...
Also, I find it funny that there are SERIOUS problems being reported in the boot log, but NOBODY fixes them. Yet, here you are removing the only output that shows there are problems...
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 4:43 PM, Aleksey Bragin <aleksey@reactos.org> wrote:
Very easy, I explained you in the previous email. If the reminder has no sense, for example as it was with NTDLL LDR debug prints – they warned about a not implemented app compat hacks querying, which was never implemented before, then there is no reason to remind about it at the load of every executable image in ReactOS.Same applies to other stuff.However, if the certain dprint is of really reminding nature, e.g. it temporarily changes behaviour of a certain code path, or shows an unimplemented code path being executed which other code may rely on – then it should obviously stay.From: Alex IonescuSent: Thursday, September 08, 2011 11:44 PMSubject: Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to DPRINTs.?And who decides? This sounds like utter BS!So while navigating it's okay to get 100000 "UIMPLEMENTED FOR PIDL" or 100 IRP unimplemented messages, but it's wrong to get other dprints?!
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 7:48 PM, Aleksey Bragin <aleksey@reactos.org> wrote:
That’d be great but it’s important to not "overdo” the job.WBR,Aleksey.From: Alex IonescuSent: Thursday, September 08, 2011 9:40 PMSubject: Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to DPRINTs.Then why not get rid of ALL similar dprints?
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 6:34 PM, Aleksey Bragin <aleksey@reactos.org> wrote:
If someone wants to implement1. Alternate resource support2. BasePostImportInit and related advanced stuff3. Application compatibility hacks supporthe should be at least that smart to see that support for those features is totally non-existant, so there is nothing to warn about.It’s similar to having this reminder in the early init stage: DPRINT1(“ReactOS is in alpha stage, some features may be missing. You have been warned!\n”);WBR,Aleksey Bragin.From: Alex IonescuSent: Thursday, September 08, 2011 8:39 PMSubject: Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to DPRINTs.For the stuff that was obviously designed to warn at least once, have you filled out bug reports for all these missing features, or do you think that someone will now remember all this missing code?
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 9:28 AM, <fireball@svn.reactos.org> wrote:
Author: fireball
Date: Thu Sep 8 08:28:41 2011
New Revision: 53635
URL: http://svn.reactos.org/svn/reactos?rev=53635&view=rev
Log:
- Downgrade some DPRINT1s to DPRINTs._______________________________________________
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev