Re: [ros-dev] [ros-diffs] [tkreuzer] 58193: [SAL.H] "Implement" all used annotations [XDK/DDK] Add missing annotations, move some prototypes to more appropriate headers [NDK] Fix a number of annotations [NDK] Use SAL2 dummy...

[Aleksey Bragin]

This is a very good thing to include into ReactOS Development Guidelines.

Regards,
Aleksey Bragin

On 20.01.2013 4:03, Timo Kreuzer wrote:
>  
>  Addition:
>  I fixed the *VERIFY macros, so that they actually work. Instead of 
>  defining them to the ASSERT macros, we now define the ASSERT macros to 
>  VERIFY, additionally casting to void to get rid of the errors.
>
>  I also modified the NT_ASSERT / NT_VERIFY macros a bit, so that on GCC 
>  builds they are closer to what MSVC builds generate.
>
>  I'd like to encourage to make use of NT_ASSERT.
>  If you don't know the differences to a "normal" ASSERT, please check 
>  out this excellent article: 
>  http://www.osronline.com/article.cfm?article=474
>
>  Timo
>
>  Am 19.01.2013 22:49, schrieb tkreuzer(a)svn.reactos.org:
> > Author: tkreuzer
> > Date: Sat Jan 19 21:49:12 2013
> > New Revision: 58193
> >
> > URL: http://svn.reactos.org/svn/reactos?rev=58193&view=rev
> > Log:
> > [SAL.H] "Implement" all used annotations
> > [XDK/DDK] Add missing annotations, move some prototypes to more 
> > appropriate headers
> > [NDK] Fix a number of annotations
> > [NDK] Use SAL2 dummys from umtypes as well