Lol, I’ve been through this with Aleksey about 30 minutes ago  ;)

Ged.

From: ros-diffs-bounces@reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of Alex Ionescu
Sent: 09 January 2009 14:18
To: ros-dev@reactos.org
Cc: ros-diffs@reactos.org
Subject: Re: [ros-diffs] [dchapyshev] 38663: - Cleanup user32, direct call to kernel space

I totally disagree with this commit.

Best regards,
Alex Ionescu

On Fri, Jan 9, 2009 at 6:33 AM, <dchapyshev@svn.reactos.org> wrote:

Author: dchapyshev
Date: Fri Jan  9 05:33:50 2009
New Revision: 38663

URL: http://svn.reactos.org/svn/reactos?rev=38663&view=rev
Log:
- Cleanup user32, direct call to kernel space

Modified:
   trunk/reactos/dll/win32/user32/controls/button.c
   trunk/reactos/dll/win32/user32/controls/combo.c
   trunk/reactos/dll/win32/user32/controls/edit.c
   trunk/reactos/dll/win32/user32/controls/icontitle.c
   trunk/reactos/dll/win32/user32/controls/listbox.c
   trunk/reactos/dll/win32/user32/controls/scrollbar.c
   trunk/reactos/dll/win32/user32/controls/static.c
   trunk/reactos/dll/win32/user32/misc/dde.c
   trunk/reactos/dll/win32/user32/misc/ddeserver.c
   trunk/reactos/dll/win32/user32/misc/desktop.c
   trunk/reactos/dll/win32/user32/misc/misc.c
   trunk/reactos/dll/win32/user32/misc/object.c
   trunk/reactos/dll/win32/user32/misc/stubs.c
   trunk/reactos/dll/win32/user32/misc/timer.c
   trunk/reactos/dll/win32/user32/misc/winsta.c
   trunk/reactos/dll/win32/user32/user32.def
   trunk/reactos/dll/win32/user32/windows/accel.c
   trunk/reactos/dll/win32/user32/windows/bitmap.c
   trunk/reactos/dll/win32/user32/windows/caret.c
   trunk/reactos/dll/win32/user32/windows/clipboard.c
   trunk/reactos/dll/win32/user32/windows/cursor.c
   trunk/reactos/dll/win32/user32/windows/dc.c
   trunk/reactos/dll/win32/user32/windows/defwnd.c
   trunk/reactos/dll/win32/user32/windows/dialog.c
   trunk/reactos/dll/win32/user32/windows/draw.c
   trunk/reactos/dll/win32/user32/windows/input.c
   trunk/reactos/dll/win32/user32/windows/mdi.c
   trunk/reactos/dll/win32/user32/windows/menu.c
   trunk/reactos/dll/win32/user32/windows/message.c
   trunk/reactos/dll/win32/user32/windows/messagebox.c
   trunk/reactos/dll/win32/user32/windows/nonclient.c
   trunk/reactos/dll/win32/user32/windows/paint.c
   trunk/reactos/dll/win32/user32/windows/window.c
   trunk/reactos/dll/win32/user32/windows/winpos.c

[This mail would be too long, it was shortened to contain the URLs only.]

Modified: trunk/reactos/dll/win32/user32/controls/button.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/button.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/combo.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/combo.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/edit.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/edit.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/icontitle.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/icontitle.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/listbox.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/listbox.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/scrollbar.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/scrollbar.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/static.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/static.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/dde.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/dde.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/ddeserver.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/ddeserver.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/desktop.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/desktop.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/misc.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/misc.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/object.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/object.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/stubs.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/stubs.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/timer.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/timer.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/winsta.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/winsta.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/user32.def
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/user32.def?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/accel.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/accel.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/bitmap.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/bitmap.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/caret.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/caret.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/clipboard.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/clipboard.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/cursor.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/cursor.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/dc.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/dc.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/defwnd.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/defwnd.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/dialog.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/dialog.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/draw.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/draw.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/input.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/input.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/mdi.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/mdi.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/menu.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/menu.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/message.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/message.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/messagebox.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/messagebox.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/nonclient.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/nonclient.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/paint.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/paint.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/window.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/window.c?rev=38663&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/winpos.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/winpos.c?rev=38663&r1=38662&r2=38663&view=diff