Hi,
-----Message d'origine----- De : ros-diffs-bounces@reactos.org [mailto:ros-diffs-bounces@reactos.org] De la part de dgorbachev@svn.reactos.org Envoyé : jeudi 14 juin 2007 18:42 À : ros-diffs@reactos.org Objet : [ros-diffs] [dgorbachev] 27174: - Hackish solution of issue #2062. - Turn off title change, as it can cause a deadlock.
Author: dgorbachev Date: Thu Jun 14 20:41:55 2007 New Revision: 27174
URL: http://svn.reactos.org/svn/reactos?rev=27174&view=rev Log:
- Hackish solution of issue #2062.
- Turn off title change, as it can cause a deadlock.
Modified: trunk/reactos/subsystems/win32/csrss/win32csr/conio.c trunk/reactos/subsystems/win32/csrss/win32csr/dllmain.c trunk/reactos/subsystems/win32/csrss/win32csr/guiconsole.c
Why hiding the real cause of bug 2062 by a hack, as you already did in r27107 for bug 2151?
See desktop icons in explorer bar. They are not correct and I know when it appeared and I known how to hack a solution. But I won't do it because I don't want to hide the real problem. IMO, you should do the same thing and search the root problem or leave the effect visible, so it won't be forgotten. If you really need to add a hack in the code, please add a comment in the C code linking to bugzilla, and add a comment in BZ saying "hackish solution committed in rXXXXX"
Hervé