Re: [ros-dev] [ros-diffs] [tkreuzer] 56478: [WIN32K] A pointer is not a handle.

[Timo Kreuzer]

Am 03.05.2012 07:47, schrieb James Tabor:
>   This is wrong, please read co_IntGetPeekMessage,,,
I find it pretty aweful to pass *HWND*_* constants as the PWND. But I
guess that fits quite well to the rest of our window manager ;-)
I'll revert, but I suggest to pass HWND to co_IntPeekMessage,
MsqPeekMessage, co_MsqPeekMouseMove, co_MsqPeekHardwareMessage,
IntGetPaintMessage and
PostTimerMessages. Almost all checks in there are for HWND anyway.
>  @@ -1727,8 +1727,8 @@
>     3: handle to the window whose messages are to be retrieved.
>     */
>          if ( ( !Window || // 1
>  -            ( Window == HWND_BOTTOM&&  CurrentMessage->Msg.hwnd ==
>  NULL ) || // 2
>  -            ( Window != HWND_BOTTOM&&  Window->head.h ==
>  CurrentMessage->Msg.hwnd ) )&&  // 3
>  +            ( Window->head.h == HWND_BOTTOM&&
>  CurrentMessage->Msg.hwnd == NULL ) || // 2
>  +            ( Window->head.h != HWND_BOTTOM&&  Window->head.h ==
>  CurrentMessage->Msg.hwnd ) )&&  // 3
>                ( ( ( MsgFilterLow == 0&&  MsgFilterHigh == 0 )&&
>  CurrentMessage->QS_Flags&  QSflags ) ||
>                  ( MsgFilterLow<= CurrentMessage->Msg.message&&
>  MsgFilterHigh>= CurrentMessage->Msg.message ) ) )
>            {
>  @@ -1790,8 +1790,8 @@
>     3: handle to the window whose messages are to be retrieved.
>     */
>          if ( ( !Window || // 1
>  -            ( Window == HWND_BOTTOM&&  CurrentMessage->Msg.hwnd ==
>  NULL ) || // 2
>  -            ( Window != HWND_BOTTOM&&  Window->head.h ==
>  CurrentMessage->Msg.hwnd ) )&&  // 3
>  +            ( Window->head.h == HWND_BOTTOM&&
>  CurrentMessage->Msg.hwnd == NULL ) || // 2
>  +            ( Window->head.h != HWND_BOTTOM&&  Window->head.h ==
>  CurrentMessage->Msg.hwnd ) )&&  // 3
>                ( ( ( MsgFilterLow == 0&&  MsgFilterHigh == 0 )&&
>  CurrentMessage->QS_Flags&  QSflags ) ||
>                  ( MsgFilterLow<= CurrentMessage->Msg.message&&
>  MsgFilterHigh>= CurrentMessage->Msg.message ) ) )
>          {
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>