Re: [ros-dev] Re: [ros-diffs] [greatlrd] 16528: The return size calculation's of GetEnvironmentVariable string was wrong. Thx to <Bizzy_D> to find out cd %windir% did not work. Now it will

Hi
W3seek have alrady fix that bug in kernel32/misc/env.c
we did not handler some case right. We did have long talk on the irc yestday
about this problem. with lates commit from w3seek. it can not be reprodues any
more. The code change you did in cmd are making the cmd bit faster, instead for
for calling reaclloc the buffer  1times it only calls when it need. But if
%param% fails it must print %param% I do not know if we are doing that yet.
I have not test all case yet.

Quoting Hartmut Birr <hartmut.birr(a)gmx.de>de>:

>   magnus(a)itkonsult-olsen.com wrote:
> >   Hi
> >  Harmurt
> >  I have test the GetEnvironmentVariable it return number of chater.
> >
> >  Our  GetEnvironmentVariable  did count 1 char as zero and so on.
> >  it did miss calcutaion by 1. instead geting 9 char it did only get 8 char.
> >
> >  This bug was expode by reactos cmd.
> >  and we do not have any bug to getting env there, in windows. When you did
> >  type echo %windir% it did print C:\ReactO before my bug fix. it should 
>  print
> >   C:\ReactOS
> >  
>  I cannot reproduce this bug. But I've found a bug in cmd.c which may eat
>  up the last character of an environment variable.
>
>  - Hartmut
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.com
>  http://reactos.com:8080/mailman/listinfo/ros-dev
>