Re: [ros-dev] [ros-diffs] [cfinck] 33824: - Add a test suite forws2_32.dll It currently tests the features I needed toadjust/implement when fixing the wininet problem. ReactOScurrently passes all tests, but fails one if you launch the test app for the sec

[gedmurphy]

It's just that you've now separated this dll test from all the others,
making it inconvenient for regular testers to use.

Timo's test framework was designed for testing win32k and its related
counterparts. Although it's well suited to incorporate other tests, they
don't belong there in my opinion.

Plus, using the Wine framework means you can submit it back to Wine.

Ged.


-----Original Message-----
From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On
Behalf Of Colin Finck
Sent: 03 June 2008 22:08
To: 'ReactOS Development List'
Subject: Re: [ros-dev] [ros-diffs] [cfinck] 33824: - Add a test suite
forws2_32.dll It currently tests the features I needed toadjust/implement
when fixing the wininet problem. ReactOScurrently passes all tests, but
fails one if you launch the test app for the sec

gedmurphy wrote:
>   Should this not be in the wine tests framework?
I don't see anything wrong with using Timo's testing framework.
It looked modular enough to be suitable for any kind of DLL testing. In
fact, my test suite code is based on the gdi32.dll test with only some minor
modifications and of course another test list.

The Wine test framework is currently only used by tests imported from Wine,
so an own test suite for ws2_32.dll might get lost there.
Also Timo's testing framework offers some interesting features like HTML
output not offered by the Wine one.
Additionally, we have a free hand here and can play with it as we want,
while we can only import and maybe make little changes to the Wine test
framework if we want to avoid a big merging mess.

Best regards,

Colin

_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev