The point of using libs is to avoid recompiling stuff to reduce build time.
Everthing that can be done with #ifdef can usually be done with link
time solutions as well.
So unless there are very strong reasons to change it, I would prefer to
keep it as it is.
In the case you described, we just need a function that does that wait
in the ACPI hal and does nothing in the other hals.
Timo
Am 09.08.2015 um 11:14 schrieb Андрей Кудравец:
Hello.
I propose to change the structure of the HAL.
i.e. to build different hal's (hal.dll, halacpi.dll etc not
from different libs (generic, acpi, apic, up, legacy etc.),
and using constructs like #ifdef _ACPI_HAL_.
For example, generic/dma.c in the acpi version need when entering
sleep mode and exit from it, you need to save the state of the dma
controller, and in non acpi hal - this is not necessary.
this is for the future.
p. S. sorry for my English if anything.
p. p. S. who speaks Russian, if not difficult, can I write in Russian
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev