Hello,
 
Thank you for the patch, however we normally do not accept patches via email. Please create a Pull Request(s) in our repository on GitHub instead, here is a step by step guide in our wiki: https://reactos.org/wiki/Commiting_Changes
 
Monday, 21 March 2022, 2:02 +03:00 from Raymond Czerny <chip@raymisoft.de>:
 
Hello,

my name is Raymond.

I have a patch for you, with a reimplentation of IsReactOS() in reactos/sdk/include/psdk/versionhelpers.h.
This function was marked FIXME.
The old check with installation directory is error prone.
My implementation read the field "ProductName" of VersionsInformation resource from shell32.dll.

A second problem, I have found in reactos/dll/win32/comdlg32/filedlg.c.
Duplicates in the function filedlg_collect_places_pidls().
My resolve used a little function collection in the files cstrlist.c and cstrlist.h.
In filedlg-snipped.c is the new code.

I don't know if this approach is desirable and where such helper functions should be placed.
So decide for yourself about their use.

I hope this little step is a good begin.

Greetings
Raymond
_______________________________________________
Ros-dev mailing list
Ros-dev@reactos.org
http://reactos.org/mailman/listinfo/ros-dev
 
--
Stas’M was here