Re: [ros-dev] Re : Fedora 13 Build Error

[James Tabor]

Hi!
I attempted to commit this, but~

I've tested Fedora 6, 8, 10 - 12 and Slackware 12.x and 13.x without
issues. Someone with Apple and FreeBSD build systems need to test
this.

Thanks for helping,
James


On Sat, Jul 31, 2010 at 6:39 AM, Colin Finck <mail(a)colinfinck.de> wrote:
>   James Tabor <jimtabor.rosdev(a)gmail.com> wrote:
> >  
> >  Nice! I will get to test slackware 13.x and the other fedora distros
> >  soon before doing the commit. 
>  You should be able to simplify your patch to:
>
>  Index: tools/cabman/cabinet.cxx
>  ===================================================================
>  --- tools/cabman/cabinet.cxx    (revision 48297)
>  +++ tools/cabman/cabinet.cxx    (working copy)
>  @@ -21,7 +21,8 @@
>   #if !defined(WIN32)
>   # include <dirent.h>
>  +# include <sys/stat.h>
>  +# include <sys/types.h>
>   #endif
>  -#if defined(__FreeBSD__) || defined(__APPLE__)
>  -# include <sys/stat.h>
>  -#endif // __FreeBSD__
>
>  Untested and mocked up, but you should get the idea :-)
>  Both added includes are part of the Open Group Base Specifications, so there
>  should be no harm in including them on all modern Unix systems.
>
>  Cheers,
>
>  Colin