Re: [ros-dev] [ros-diffs] [cgutman] 41783: - Fix return value of tdiGetMibForIfEntity so it doesn't return a failure status on success

[Cameron Gutman]

It's not a hack. We know we have succeded if we reach that  code  
because we check for failure earlier. The problem is that status was  
the return value of DeviceIoControl which returns nonzero for success  
but zero is success in ntstatus.

On Jul 6, 2009, at 4:44 AM, "Ged" <gedmurphy(a)gmail.com> wrote:

>   This looks hackish
>  It also breaks the log as you're potentially returning something  
>  different from what the log states
>
>  -----Original Message-----
>  From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs- 
>  bounces(a)reactos.org] On Behalf Of cgutman(a)svn.reactos.org
>  Sent: 06 July 2009 08:54
>  To: ros-diffs(a)reactos.org
>  Subject: [ros-diffs] [cgutman] 41783: - Fix return value of  
>  tdiGetMibForIfEntity so it doesn't return a failure status on success
>
>  Author: cgutman
>  Date: Mon Jul  6 11:54:28 2009
>  New Revision: 41783
>
>  URL: http://svn.reactos.org/svn/reactos?rev=41783&view=rev
>  Log:
>  - Fix return value of tdiGetMibForIfEntity so it doesn't return a  
>  failure status on success
>
>  Modified:
>     trunk/reactos/dll/win32/iphlpapi/ifenum_reactos.c
>
>  Modified: trunk/reactos/dll/win32/iphlpapi/ifenum_reactos.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/iphlpapi/ifenum_…
>  === 
>  === 
>  === 
>  =====================================================================
>  --- trunk/reactos/dll/win32/iphlpapi/ifenum_reactos.c [iso-8859-1]  
>  (original)
>  +++ trunk/reactos/dll/win32/iphlpapi/ifenum_reactos.c [iso-8859-1]  
>  Mon Jul  6 11:54:28 2009
>  @@ -280,7 +280,7 @@
>             entry->ent.if_descr);
>      TRACE("} status %08x\n",status);
>
>  -    return status;
>  +    return STATUS_SUCCESS;
>  }
>
>  NTSTATUS tdiGetEntityIDSet( HANDLE tcpFile,
>
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev