Re: [ros-dev] Console Csrss Handle Errors

[Alex Ionescu]

Casper Hornstrup wrote:

>    
>
> >  -----Original Message-----
> > From: ros-dev-bounces(a)reactos.com [mailto:[e-mail]] On Behalf Of Alex
> > Ionescu
> > Sent: 11. juli 2005 21:33
> > To: ReactOS Development List
> > Subject: Re: [ros-dev] Console Csrss Handle Errors
> >
> > Casper Hornstrup wrote:
> >
> >     
> >
> > >  I thought we already established that such big
> > > patches are not good for us.
> > >
> > >
> > >
> > >       
> > >  
> > No, we established that misc branches and patches containing 100
> > unrelated fixes are not good for us.
> >
> > I have not yet seen how large patches which are specific to a single
> > feature/fix, and which come with extremly detailed changelogs and
> > separated .diff files for easy reading are bad for us. Let me know if
> > you've decided this new policy, I haven't seen a vote on it.
> >
> > Best regards,
> > Alex Ionescu
> >
> >     
> >
> > >Casper
> > >      
> > > 
> We can vote on it, but we've seen many arguments on the issue during the previous
> vote:
> http://reactos.com/wiki/index.php/Voting/Miscelanea_branches
>   
>  
I guess I wasn't clear in my email. This is not a misc patch/branch.

>  Issues like big patches are much harder to review and
> it's much harder to pinpoint regressions caused by big patches.
>   
>  
So, should we revert rbuild? It was a pretty big patch too. And I can 
name a couple of other ones... (let's not get started into to how many 
regressions rbuild caused :)

I cannot please you Casper, I'm sorry. First I make small changelogs, 
and you complain they are too small. Then I make large ones, and you 
complain they are too big. Then you tell me to use branches, I do, and 
you complain that it was too broad/large, and that I should split up 
patches and work on single features too. Now I spend two weeks on a 
patch which targets a single thing, and you compain again. Would it be 
better for you if I just left the project? Nothing sucks more then 
spending 2 weeks working on something (And YES it has and will still be 
reviewed by other devs) to be told "I don't want that'. I find that 
disappointing.

Best regards,
Alex Ionescu

>  Casper
>
>
> _______________________________________________
> Ros-dev mailing list
> Ros-dev(a)reactos.com
> http://reactos.com:8080/mailman/listinfo/ros-dev
>
>   
>