Hi Casper,
Perhaps we should move the whole rosapps folder also in the repository into the reactos tree, and add it permanently to ReactOS.XML ?
That would mean you need to always checkout rosapps. I was thinking we could checkout modules other than reactos into reactos/modules/ and use xi:fallback to make it optional. E.g.
<xi:include href="rosapps/directory.xml"> xi:fallback <xi:include href="empty.xml" /> </xi:fallback> </xi:include>
If modules/rosapps/directory.xml does not exist, then empty.xml is included instead, thus making rosapps an optional dependency.
Good idea, but when moving rosapps into reactos/modules currently the build failes for me with this error:
# Creating directories...done # Unpacking WINE resources...done # Generating test support code...done # Generating proxy makefiles...done # Checking automatic dependencies...File 'modules\cmdutils\mode\mode.c' not found. # make.exe: *** [makefile.auto] Error 1
Somehow the build system seems to forget the 'rosapps' subfolder when generating the paths in makefile.auto: It should be "'modules\rosapps\cmdutils\mode\mode.c'", not "'modules\cmdutils\mode\mode.c'".
Regards,
Martin