On 18.11.2011 19:35, Cameron Gutman wrote:
Let's not rule out the possibility that the bitmap functions are broken btw ;)
I doubt this is the case, since we use bitmap functions all over ROS. I know we use them to manage ports in TCP/IP and also to manage map registers for DMA in HAL. Neither of those uses display any signs of malfunctioning in the bitmap functions. There are also many more uses in Cm and Ldr. I just doubt that a severe bug that shows up so regularly using standard bitmap APIs could go unfixed with so many uses of those functions.
Plus, we already have an Rtl bitmap winetest in ntdll which passes all tests.
Once, I had to add yet another test to fix the behavior. It also looked very good back then, with the exception that bitmaps were not used that much in ReactOS and issue did not manifest itself.
As for now, I'm 99% sure bitmap code works as expected.
WBR, Aleksey.