Re: [ros-dev] [ros-diffs] [greatlrd] 37343: Bugfix : Do not link toLPDDRAWI_DIRECTDRAW_INT->lpLink when we do not have anyLPDDRAWI_DIRECTDRAW_INT->lpLcl

[Magnus Olsen]

1. if u warp code with PSEH it can not be optimze with the compiler (acroing 
KJK when he told me try avoid PSEH, long time ago).

2. This is old code I had lying around, the ddraw.dll was devloper frist in 
MSVC then port to GCC and reactos build system.

3. If u look how ms ddraw.dll  doing their call they using thuse api.

I can rewrite the code later to use PSEH, but I do not known when I have 
time todo that.
at momment I cleaing up my hd with old dx code. I hope within 1-2 month I 
commit eveything I have lying around for ddraw.dll. I have a girl friend 
now. so do not expect equal many commit as I use todo, or fast bugfix. Now I 
will only focuse on reactx when I got some time over.




----- Original Message ----- 
From: "James Tabor" <jimtabor.rosdev(a)gmail.com>
To: "ReactOS Development List" <ros-dev(a)reactos.org>
Sent: Friday, November 14, 2008 10:18 AM
Subject: Re: [ros-dev] [ros-diffs] [greatlrd] 37343: Bugfix : Do not link 
toLPDDRAWI_DIRECTDRAW_INT->lpLink when we do not have 
anyLPDDRAWI_DIRECTDRAW_INT->lpLcl


>   Yes, I agree, we have SEH and we should just use that.
> Keep
>  IsBadXxxXxx for compatibility reasons only.
>
>  On Thu, Nov 13, 2008 at 2:59 PM, gedmurphy <gedmurphy(a)gmail.com> wrote:
> >   Is it not time to start getting rid of
> > IsBadWritePtr and friends?
> >  I don't see a good reason for these in our own code, especially when we 
> >  can just use SEH directly.
> >
> >  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev