Re: [ros-dev] [ros-diffs] [gedmurphy] 67563: [DDK] Fix the FS filter callback definitions

[Ged Murphy]

Well this is a weird one, the DDK says these callbacks are cdecl (missing NTAPI) and
anyone building against the DDK will obviously declare their callbacks to match this
convention.  However internally, windows uses stdcall for these callbacks.

I can't find much by way of problems people have encountered with this, so why
aren't people seeing problems with the way the stack is cleaned up? Anyone have any
ideas before I blindly revert this change?

Ged.


-----Original Message-----
From: Ros-diffs [mailto:[e-mail]] On Behalf Of
gedmurphy(a)svn.reactos.org
Sent: 05 May 2015 19:54
To: ros-diffs(a)reactos.org
Subject: [ros-diffs] [gedmurphy] 67563: [DDK] Fix the FS filter callback definitions

Author: gedmurphy
Date: Tue May  5 18:54:28 2015
New Revision: 67563

URL: http://svn.reactos.org/svn/reactos?rev=67563&view=rev
Log:
[DDK]
Fix the FS filter callback definitions

Modified:
    trunk/reactos/include/ddk/ntifs.h

Modified: trunk/reactos/include/ddk/ntifs.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntifs.h?rev=67…
==============================================================================
--- trunk/reactos/include/ddk/ntifs.h	[iso-8859-1] (original)
+++ trunk/reactos/include/ddk/ntifs.h	[iso-8859-1] Tue May  5 18:54:28 2015
@@ -4890,12 +4890,12 @@
 } FS_FILTER_CALLBACK_DATA, *PFS_FILTER_CALLBACK_DATA;
 
 typedef NTSTATUS
-(NTAPI *PFS_FILTER_CALLBACK) (
+(*PFS_FILTER_CALLBACK) (
   _In_ PFS_FILTER_CALLBACK_DATA Data,
   _Out_ PVOID *CompletionContext);
 
 typedef VOID
-(NTAPI *PFS_FILTER_COMPLETION_CALLBACK) (
+(*PFS_FILTER_COMPLETION_CALLBACK) (
   _In_ PFS_FILTER_CALLBACK_DATA Data,
   _In_ NTSTATUS OperationStatus,
   _In_ PVOID CompletionContext);