Re: [ros-dev] [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented

[Javier Agustìn Fernàndez Arroyo]

bad one, i guess
that would slow down development a lot

On Thu, Apr 15, 2010 at 11:14 AM, Peter Millerchip <
[e-mail]> wrote:
> Yes, I agree too - trunk should ideally not contain non-working code.
> Maybe non-working drivers belong in a branch until they've been fully
> tested?
>
> Maybe trunk should be locked to everyone except a "trunk manager" who
> accepts patches from people, or merges different branches in to trunk.
> That way trunk can remain stable and lean. Would that be a good idea,
> or a bad one?
>
> On 15 April 2010 09:46, Aleksey Bragin [e-mail] wrote:
> > I fully agree with Ged. I know it's fun to create something from scratch
>
> (I
> > used and will still do, of course) and work in an explored area, however
>
> I
> > think there should be some control. If you really want to work on that
>
> and
> > nothing else - we have rosapps/drivers. In my opinion, trunk has no place
> > for non-working drivers which aren't really a top priority (at least, I
> > didn't include fastfat_new to the build process so noone wastes time
> > compiling a driver which is needed only by 2 or 3 developers).
> >
> > WBR,
> > Aleksey.
> >
> > On Apr 15, 2010, at 11:05 AM, Ged Murphy wrote:
> > > I don't mean to sound like a broken record, and I also understand that
>
> the
> > > project allows people to work on whatever they want to. But with the
>
> project
> > > in such a state at the moment, is a pcmcia bus driver really the best
>
> thing
> > > to be working on?
> > > I'm all for project freedom, but you would hope people to have the
> > > diligence to work on areas which might help to stop the project from
> > > failing.
> > >
> > > Maybe I just don't get it anymore and I'm behind the times, but what
> > > happened to the days when people used to work on important things?
> > >
> > > Your nagging ex-dev,
> > > Ged.
> > >
> > > -----Original Message-----
> > > From: [e-mail] [mailto:
>
> [e-mail]]
> > > On Behalf Of [e-mail]
> > > Sent: 15 April 2010 02:59
> > > To: [e-mail]
> > > Subject: [ros-diffs] [cgutman] 46876: [PCMCIA] - Add a mostly stubbed
> > > PCMCIA driver - pcmcia.c is complete but fdo.c and pdo.c are completely
> > > unimplemented
> > >
> > > Author: cgutman
> > > Date: Thu Apr 15 03:59:15 2010
> > > New Revision: 46876
> > >
> > > URL: http://svn.reactos.org/svn/reactos?rev=46876&view=rev
> > > Log:
> > > [PCMCIA]
> > > Add a mostly stubbed PCMCIA driver
> > > pcmcia.c is complete but fdo.c and pdo.c are completely unimplemented
> > >
> > > Added:
> > >    trunk/reactos/drivers/bus/pcmcia/
> > >    trunk/reactos/drivers/bus/pcmcia/fdo.c   (with props)
> > >    trunk/reactos/drivers/bus/pcmcia/pcmcia.c   (with props)
> > >    trunk/reactos/drivers/bus/pcmcia/pcmcia.h   (with props)
> > >    trunk/reactos/drivers/bus/pcmcia/pcmcia.rbuild   (with props)
> > >    trunk/reactos/drivers/bus/pcmcia/pcmcia.rc   (with props)
> > >    trunk/reactos/drivers/bus/pcmcia/pdo.c   (with props)
> > > Modified:
> > >    trunk/reactos/drivers/bus/directory.rbuild
> > >
> > > Ros-dev mailing list
> > > [e-mail]
> > > http://www.reactos.org/mailman/listinfo/ros-dev
> >
> > Ros-dev mailing list
> > [e-mail]
> > http://www.reactos.org/mailman/listinfo/ros-dev
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev