5 May
2015
5 May
'15
3:01 p.m.
Am 30.04.2015 um 19:51 schrieb stack exchange:
I implemented this functionallity, so the installer
can now create one
or more logical partitions and can also install it there. There are
two issues though:
1. When multiple logical drives exist and they are deleted the
installer crashes. This is IMO just a minor problem, because you can
still install, yu just have to think ahead of what you want. I will
look into this later.
2. This is IMO the more important issue. I verified with a GParted ISO
the partitions and they are corrupted. At first I thought I did
something wrong, but after working on this for several weeks now I'm
not so convinced anymore. When I dump the partition table with my
code, it looks exactly as the dump that it would generate when I
create the same layout with gparted, so it should work. So my
assumption is that the implementation in
NtDeviceIoControlFile(IOCTL_DISK_SET_DRIVE_LAYOUT) may be the cause.
On the other hand, when I create only primary partitions (which the
existing code can do) then gparted doesn't report any errors, so it
may only be the case when dealing with logical partitions.
In my JIRA issue (https://jira.reactos.org/browse/CORE-9641) I reported
four problems with this patch.
Two of them are now fixed with the patch that I attached. This is the
issue that setup crashed when deleting logical partitions, and the other
one was that you couldn't create a logical partition by pressing ENTER,
you had to use the 'L' key and create it manually first.
In my opinion the problems of this issue are resolved with that. The
other two problems ("can't boot from a logical partition" and
"corrupted
partition layout when using logical partitions") are seperate items and
I would rather create a seperate issue for each of them. From my side I
would say that this issue can be closed (after accepting the patch and
testing it).
mfg,
Gerhard