Couldn't we make a branch with the applied Changes, and leave Trunk with the non-applied Changes? At least that way, we'd have a decent way of being able to fix NPFS, without the Trunk being affected by any unwelcome changes
On 11/4/05, Alex Ionescu ionucu@videotron.ca wrote:
Casper Hornstrup wrote:
-----Original Message----- From: ros-dev-bounces@reactos.org [mailto:ros-dev-bounces@reactos.org] On Behalf Of Hartmut Birr Sent: 4. november 2005 21:03 To: ReactOS Development List Subject: Re: [ros-dev] NPFS problems
Thomas Weidenmueller wrote:
Casper Hornstrup wrote:
You don't think the changes should be reverted?
As I said it's ok to revert them, but the changes are correct. Our npfs is the problem and needs to be fixed. Unfortunately I'm not really familiar with our npfs code, otherwise I would've taken a look at it and fixed it in the first place. Herve is about to revert the changes for now ;)
- Thomas
Thomas's changes are correct. The problem is the special mode in npfs, which I've removed. The special mode was triggered by opening or creating a pipe with the share disposition read and write. This is wrong. I think, the special mode must be triggered, if the pipe is only open for read attributes.
- Hartmut
I'm sure they are, but I'm also sure that many would prefer "incorrect-and-working" over "correct-and-non-working" if those were the only two choices.
Casper
I wouldn't.
"incorrect-and-working" leads to stuff never being made correct.
Best regards, Alex Ionescu _______________________________________________ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
-- "I had a handle on life, but then it broke"