Re: [ros-dev] Re : [ros-diffs] [sginsberg] 43789: - Replace broken implementation of HalpCalibrateStallExecution with a new implementation by a mysterious HAL ninja and myself. The old implementation calculated the stall count factor incorrectly and produced

[Aleksey Bragin]

I tested the new implementation in same vmware environment, 5 boot  
ups, here are values of the stall factor:
921
2426
873
2405
2405

I can't say it's a huge success over the old implementation (it  
provided values in the 1000 - 4000 range in the same environment),  
taking in mind how more complex the code became (it even has its own  
ISR handler embedded into the function!!).

WBR,
Aleksey Bragin.

On Oct 27, 2009, at 4:15 PM, Alex Ionescu wrote:

>   And it continues to do its job today -- you added code
> telling UniATA
>  "wait between 500ms and 5seconds", and it's working fine in trunk.
>
>  Why are people complaining "it takes UniATA up to 5 seconds to boot"
>  when this is exactly the code you intended to add?
>
>  Also:
>
>  "Maybe theres a better way to get this done, but it was enough for
>  testing and did its job well."
>
>  Is now my all-time favourite quote, ever.
>
>  I bet Hitler would've said the same at Nuremberg....
>
>  On 2009-10-27, at 8:50 AM, Daniel Reimer wrote:
>
> >   These timers were added because some SATA
> > adapters are fucking  
> >  slow in
> >  initializing and uniata would continue too early for them and this
> >  results in failures. Maybe theres a better way to get this done, but
> >  it
> >  was enough for testing and did its job well.
> >
> >  Alex Ionescu schrieb:
> > > The real problem is that UniATA is full of shit code from Aleksey
> > > that
> > > does things like StallExecution(100000). Microsoft says not to go
> > > over
> > > 50, but hey, this is ReactOS....reading docs?? HAHAHA!!
> > >
> > > I've looked over Stefan's code and it is perfect, and sets a correct
> > > stall factor.
> > >
> > > On 2009-10-27, at 8:24 AM, Sylvain Petreolle wrote:
> > >
> > >> It was present here in VirtualBox  3.0.8 for some time
> > >> and disappeared after Stefan's change for exception management.
> > >> Kind regards,
> > >> Sylvain Petreolle
> > >>
> > >>
> > >>    *De :* Gabriel ilardi <gabrielilardi(a)hotmail.it
> > >>    <mailto:[e-mail]>>
> > >>    *À :* ros-dev &lt;ros-dev(a)reactos.org <mailto:[e-mail]>>
> > >>    *Envoyé le :* Mar 27 Octobre 2009, 11 h 44 min 19 s
> > >>    *Objet :* Re: [ros-dev] [ros-diffs] [sginsberg] 43789: - Replace
> > >>    broken implementation of HalpCalibrateStallExecution with a new
> > >>    implementation by a mysterious HAL ninja and myself. The old
> > >>    implementation calculated the stall count factor incorrectly and
> > >>    produced
> > >>
> > >>    Hi Johannes,
> > >>
> > >>    It wasn't present for VirtualBox though, at least for me.
> > >>
> > >>    Best regards,
> > >>    Gabriel.
> > >>
> > >>> Date: Tue, 27 Oct 2009 11:34:03 +0100
> > >>> From: janderwald(a)reactos.org <mailto:[e-mail]>
> > >>> To: ros-dev(a)reactos.org <mailto:[e-mail]>
> > >>> Subject: Re: [ros-dev] [ros-diffs] [sginsberg] 43789: - Replace
> > >>    broken implementation of HalpCalibrateStallExecution with a new
> > >>    implementation by a mysterious HAL ninja and myself. The old
> > >>    implementation calculated the stall count factor incorrectly and
> > >>    produced bogus resu
> > >>>
> > >>> Gabriel ilardi schrieb:
> > >>>> 2) In second stage when loading UniATA, it stays there for
> > >>    about 4-5
> > >>>> seconds, there was no delay before.
> > >>>>
> > >>> Hi,
> > >>>
> > >>> The UniATA delay in 2nd stage was already present before that
> > >>    commit.
> > >>> However, only in VMware.
> > >>>>
> > >>>> Best regards,
> > >>>> Gabriel.
> > >>>>
> > >>> Best regards,
> > >>> Johannes Anderwald
> > >
> > > Best regards,
> > > Alex Ionescu 
>  Best regards,
>  Alex Ionescu